On Mon, Apr 18, 2022 at 02:34:36AM +0530, Kuldeep Singh wrote: > Convert Qualcomm BAM DMA controller binding to DT schema format using > json schema. > > Signed-off-by: Kuldeep Singh <singh.kuldeep87k@xxxxxxxxx> > --- > v3: > - Address Krzysztof Comments > - qcom,ee as required property > - Use boolean type instead of flag > - Add min/max to qcom,ee > - skip clocks, as it's users are not fixed > --- > v2: > - Use dma-cells > - Set additionalProperties to false > --- > .../devicetree/bindings/dma/qcom,bam-dma.yaml | 97 +++++++++++++++++++ > .../devicetree/bindings/dma/qcom_bam_dma.txt | 52 ---------- > 2 files changed, 97 insertions(+), 52 deletions(-) > create mode 100644 Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml > delete mode 100644 Documentation/devicetree/bindings/dma/qcom_bam_dma.txt > > diff --git a/Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml b/Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml > new file mode 100644 > index 000000000000..02393ec2eedd > --- /dev/null > +++ b/Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml > @@ -0,0 +1,97 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/dma/qcom,bam-dma.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Qualcomm Technologies Inc BAM DMA controller > + > +maintainers: > + - Andy Gross <agross@xxxxxxxxxx> > + - Bjorn Andersson <bjorn.andersson@xxxxxxxxxx> > + > +allOf: > + - $ref: "dma-controller.yaml#" > + > +properties: > + compatible: > + enum: > + - qcom,bam-v1.3.0 > + - qcom,bam-v1.4.0 > + - qcom,bam-v1.7.0 We've lost the mapping to SoCs. Please add as comments. > + > + clocks: > + maxItems: 1 > + > + clock-names: > + items: > + - const: bam_clk > + > + "#dma-cells": > + const: 1 > + > + interrupts: > + maxItems: 1 > + > + iommus: > + minItems: 1 > + maxItems: 4 > + > + num-channels: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: > + Indicates supported number of DMA channels in a remotely controlled bam. > + > + qcom,controlled-remotely: > + type: boolean > + description: > + Indicates that the bam is controlled by remote proccessor i.e. execution > + environment. > + > + qcom,ee: > + $ref: /schemas/types.yaml#/definitions/uint32 > + minimum: 0 > + maximum: 7 > + description: > + Indicates the active Execution Environment identifier (0-7) used in the > + secure world. > + > + qcom,num-ees: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: > + Indicates supported number of Execution Environments in a remotely > + controlled bam. > + > + qcom,powered-remotely: > + type: boolean > + description: > + Indicates that the bam is powered up by a remote processor but must be > + initialized by the local processor. > + > + reg: > + maxItems: 1 > + > +required: > + - compatible > + - "#dma-cells" > + - interrupts > + - qcom,ee > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/interrupt-controller/arm-gic.h> > + #include <dt-bindings/clock/qcom,gcc-msm8974.h> > + > + dma-controller@f9944000 { > + compatible = "qcom,bam-v1.4.0"; > + reg = <0xf9944000 0x15000>; > + interrupts = <GIC_SPI 94 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&gcc GCC_BLSP2_AHB_CLK>; > + clock-names = "bam_clk"; > + #dma-cells = <1>; > + qcom,ee = <0>; > + }; > +... > diff --git a/Documentation/devicetree/bindings/dma/qcom_bam_dma.txt b/Documentation/devicetree/bindings/dma/qcom_bam_dma.txt > deleted file mode 100644 > index 6e9a5497b3f2..000000000000 > --- a/Documentation/devicetree/bindings/dma/qcom_bam_dma.txt > +++ /dev/null > @@ -1,52 +0,0 @@ > -QCOM BAM DMA controller > - > -Required properties: > -- compatible: must be one of the following: > - * "qcom,bam-v1.4.0" for MSM8974, APQ8074 and APQ8084 > - * "qcom,bam-v1.3.0" for APQ8064, IPQ8064 and MSM8960 > - * "qcom,bam-v1.7.0" for MSM8916 > -- reg: Address range for DMA registers > -- interrupts: Should contain the one interrupt shared by all channels > -- #dma-cells: must be <1>, the cell in the dmas property of the client device > - represents the channel number > -- clocks: required clock > -- clock-names: must contain "bam_clk" entry > -- qcom,ee : indicates the active Execution Environment identifier (0-7) used in > - the secure world. > -- qcom,controlled-remotely : optional, indicates that the bam is controlled by > - remote proccessor i.e. execution environment. > -- qcom,powered-remotely : optional, indicates that the bam is powered up by > - a remote processor but must be initialized by the local processor. > -- num-channels : optional, indicates supported number of DMA channels in a > - remotely controlled bam. > -- qcom,num-ees : optional, indicates supported number of Execution Environments > - in a remotely controlled bam. > - > -Example: > - > - uart-bam: dma@f9984000 = { > - compatible = "qcom,bam-v1.4.0"; > - reg = <0xf9984000 0x15000>; > - interrupts = <0 94 0>; > - clocks = <&gcc GCC_BAM_DMA_AHB_CLK>; > - clock-names = "bam_clk"; > - #dma-cells = <1>; > - qcom,ee = <0>; > - }; > - > -DMA clients must use the format described in the dma.txt file, using a two cell > -specifier for each channel. > - > -Example: > - serial@f991e000 { > - compatible = "qcom,msm-uart"; > - reg = <0xf991e000 0x1000> > - <0xf9944000 0x19000>; > - interrupts = <0 108 0>; > - clocks = <&gcc GCC_BLSP1_UART2_APPS_CLK>, > - <&gcc GCC_BLSP1_AHB_CLK>; > - clock-names = "core", "iface"; > - > - dmas = <&uart-bam 0>, <&uart-bam 1>; > - dma-names = "rx", "tx"; > - }; > -- > 2.25.1 > >
