>> The tasklet is an old API which will be deprecated, workqueue API >> cab be used instead of them. >> > > Thank you for your patch. There is something to discuss/improve. > >> This patch replaces the tasklet usage in drivers/dma/* with a >> simple work. > > Minor nits: > > 1. Don't use "this patch". > https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95 > 2. Use subject prefix matching subsystem (git log --oneline) Thank you. Will have it updated. > >> >> Github: https://github.com/KSPP/linux/issues/94 > > 3. No external references to some issue management systems, change-ids > etc. Lore link could work, but it's not relevant here, I guess. We have had other tasks in the past which have carried the links. Ideally, I would like to Keep it, I will leave it to the maintainers. Thanks.