On 06-08-21, 18:29, Andy Shevchenko wrote: > On Fri, Aug 06, 2021 at 07:14:50PM +0530, Vinod Koul wrote: > > On 02-08-21, 20:55, Andy Shevchenko wrote: > > > While IRQ test agaist the returned variable in practice is a good enough > > > there is still a room for theoretical mistake in case the vIRQ of the > > > device contains the same error code that acpi_register_gsi() may return. > > > Due to this, check for error code separately from matching the vIRQs. > > > > > > Besides that, append documentation to tell why acpi_gsi_to_irq() can't > > > be used and we call acpi_register_gsi() instead. > > > > patch fails to apply, pls rebase > > I don't see that you applied the previous patch [1]. > Care to apply it, please? Sorry, somehow that one was pushed to queue but never got applied! Have applied both now > > [1]: https://lore.kernel.org/dmaengine/20210730202715.24375-1-andriy.shevchenko@xxxxxxxxxxxxxxx/T/#u > > -- > With Best Regards, > Andy Shevchenko > -- ~Vinod