06.08.2020 10:30, Rajesh Gumasta пишет: > +static struct dma_async_tx_descriptor *tegra_dma_prep_dma_memset( > + struct dma_chan *dc, dma_addr_t dest, int value, size_t len, > + unsigned long flags) > +{ This looks and reads okay, although the following style of code's formatting is a bit more common for the kernel: static struct dma_async_tx_descriptor * tegra_dma_prep_dma_memset(struct dma_chan *dc, dma_addr_t dest, int value, size_t len, unsigned long flags) You could make this small improvement in a v3. Same for all similar cases in the code.