Re: [PATCH 2/3] dmaengine: xilinx: dpdma: add missing kernel doc

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Vinod,

Thank you for the patch.

On Sat, Jul 18, 2020 at 07:22:00PM +0530, Vinod Koul wrote:
> xilinx_dpdma_sw_desc_set_dma_addrs() documentation is missing describing
> 'xdev', so add it
> 
> drivers/dma/xilinx/xilinx_dpdma.c:313: warning: Function parameter or
> member 'xdev' not described in 'xilinx_dpdma_sw_desc_set_dma_addrs'
> 
> Signed-off-by: Vinod Koul <vkoul@xxxxxxxxxx>

Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>

> ---
>  drivers/dma/xilinx/xilinx_dpdma.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/dma/xilinx/xilinx_dpdma.c b/drivers/dma/xilinx/xilinx_dpdma.c
> index 8e602378f2dc..430f3714f6a3 100644
> --- a/drivers/dma/xilinx/xilinx_dpdma.c
> +++ b/drivers/dma/xilinx/xilinx_dpdma.c
> @@ -295,6 +295,7 @@ static inline void dpdma_set(void __iomem *base, u32 offset, u32 set)
>  
>  /**
>   * xilinx_dpdma_sw_desc_set_dma_addrs - Set DMA addresses in the descriptor
> + * @xdev: DPDMA device
>   * @sw_desc: The software descriptor in which to set DMA addresses
>   * @prev: The previous descriptor
>   * @dma_addr: array of dma addresses

-- 
Regards,

Laurent Pinchart



[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux PCI]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux