Re: [PATCH v6 5/6] dmaengine: xilinx: dpdma: Add debugfs support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Vinod,

On Wed, Jul 15, 2020 at 04:31:30PM +0530, Vinod Koul wrote:
> On 08-07-20, 23:19, Laurent Pinchart wrote:
> > +static int xilinx_dpdma_debugfs_init(struct device *dev)
> > +{
> > +	int err;
> > +	struct dentry *xilinx_dpdma_debugfs_dir, *xilinx_dpdma_debugfs_file;
> > +
> > +	dpdma_debugfs.testcase = DPDMA_TC_NONE;
> > +
> > +	xilinx_dpdma_debugfs_dir = debugfs_create_dir("dpdma", NULL);
> 
> can you please use the dma_dev->dbg_dev_root, we are already creating
> /sys/kernel/debug/dmaengine/<device>/

Good point, I'll fix that.

-- 
Regards,

Laurent Pinchart



[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux PCI]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux