Hi Vinod, On Wed, Jul 15, 2020 at 04:31:30PM +0530, Vinod Koul wrote: > On 08-07-20, 23:19, Laurent Pinchart wrote: > > +static int xilinx_dpdma_debugfs_init(struct device *dev) > > +{ > > + int err; > > + struct dentry *xilinx_dpdma_debugfs_dir, *xilinx_dpdma_debugfs_file; > > + > > + dpdma_debugfs.testcase = DPDMA_TC_NONE; > > + > > + xilinx_dpdma_debugfs_dir = debugfs_create_dir("dpdma", NULL); > > can you please use the dma_dev->dbg_dev_root, we are already creating > /sys/kernel/debug/dmaengine/<device>/ Good point, I'll fix that. -- Regards, Laurent Pinchart