On 10-07-20, 12:45, Serge Semin wrote: > On Fri, Jul 10, 2020 at 11:51:23AM +0300, Andy Shevchenko wrote: > > On Fri, Jul 10, 2020 at 01:45:47AM +0300, Serge Semin wrote: > > > Since some DW DMA controllers (like one installed on Baikal-T1 SoC) may > > > have non-uniform DMA capabilities per device channels, let's add > > > the DW DMA specific device_caps callback to expose that specifics up to > > > the DMA consumer. It's a dummy function for now. We'll fill it in with > > > capabilities overrides in the next commits. > > > > > Just a reminder (mainly to Vinod) of my view to this. > > Unneeded churn, should be folded to patch 9. > > Just to remind (mainly to Vinod). That's Andy's bikeshedding. > This isn't a churn, since it's totally normal to design the patchset in this way: > introduce a callback, then fill it in with functionality. Looking at both patches, they do one thing, so please fold them in.. -- ~Vinod