On 20/01/2019 11:47, Vinod Koul wrote: > On 16-01-19, 11:53, Gustavo Pimentel wrote: > >>>> + /* Free irqs */ >>> >>> But devm will automatically free it, no ? >> >> Yes, it shouldn't be there. I'll remove it. > > Nope this is correct. we need to ensure irqs are freed and tasklets are > quiesced otherwise you can end up with a case when a spurious interrupt > and then tasklets spinning while core unrolls. devm for irq is not a > good idea unless you really know what you are doing! > Ok. Nice explanation.
