On Sun, Jan 20, 2019 at 4:38 PM Angus Ainslie <angus@xxxxxxxx> wrote: > > Hi Daniel, > > On 2019-01-20 02:58, Daniel Baluta wrote: > > On Sun, Jan 20, 2019 at 4:32 AM Angus Ainslie (Purism) <angus@xxxxxxxx> > > wrote: > >> > >> On i.mx8 mscale B0 chip, AHB/SDMA clock ratio 2:1 can't be supportted, > >> since SDMA clock ratio has to be increased to 250Mhz, AHB can't reach > >> to 500Mhz, so use 1:1 instead. > >> > >> based on NXP commit MLK-16841-1 > > > > Hi Angus, > > > > Thanks for doing this! > > > > I'm not sure specifying the MLK here helps. I think it would be better > > to somehow add the original Signed-off-by and mention that the commit > > was pulled from NXP linux-imx tree. > > If it was exactly the same patch I would have but as I added the lines > in > sdma_run_channel0 I didn't think it would be right to put signed off by > "Robin Gong <yibin.gong@xxxxxxx>" as the code isn't what he signed off > on. I see your point. I often encounter this scenario when sending patches. I think the best solution would be to mention in the commit message the author of the initial patch which you based your work on.
