Hi Angelo,
On Sat, Jun 30, 2018 at 3:42 PM Angelo Dureghello <angelo@xxxxxxxx> wrote:
> fixed mostly all, but sorry, i have still two questions before
> proceeding,
>
> On Thu, Jun 28, 2018 at 11:53:41AM +0530, Vinod wrote:
> It is not clear to me now how the initial header should be (i guess for
> all the 3 c files at this point).
>
> Do you want just something as :
>
> // SPDX-License-Identifier: GPL-2.0
> // Copyright (c) 2013-2014 Freescale Semiconductor, Inc
> // Copyright (c) 2017 Sysam, Angelo Dureghello <angelo@xxxxxxxx>
>
> And nothing else ?
Looks good to me.
> Majority of the files in the dma folder has also generally a line with
> the file name and path, a brief driver explaination and the reduced GPL
File names and path are superfluous, and annoying, considering move/rename
later.
> licence text, and, as imx-sdma.c often copyrights at the end. So what is
Reduced license text is no longer needed with the right SPDX header.
> the current rule ?
Copyright should be retained.
> > > +static int __init mcf_edma_init(void)
> > > +{
> > > + return platform_driver_register(&mcf_edma_driver);
> > > +}
> > > +subsys_initcall(mcf_edma_init);
> >
> > why subsys_initcall?
> >
>
> I find subsys_initcall in several dma drivers, my understanding is that
> it initializes the driver before other drivers can use it.
> It also sets the driver as built in only.
> This seems ok for my case.
Indeed. If DMAC drivers are initialized before normal device drivers (which
can be DMA slaves), probe deferral can be avoided.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe dmaengine" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
