On 28-06-18, 08:50, Geert Uytterhoeven wrote: > Hi Vinod, > > On Thu, Jun 28, 2018 at 8:29 AM Vinod <vkoul@xxxxxxxxxx> wrote: > > On 22-06-18, 11:44, Angelo Dureghello wrote: > > > obj-$(CONFIG_EP93XX_DMA) += ep93xx_dma.o > > > obj-$(CONFIG_FSL_DMA) += fsldma.o > > > obj-$(CONFIG_FSL_EDMA) += fsl-edma.o fsl-edma-common.o > > > +obj-$(CONFIG_MCF_EDMA) += mcf-edma.o fsl-edma-common.o > > > > that makes kernel have two copies of common.o one in thsi driver and one > > Does it? It's a common pattern in several Makefiles (e.g. > drivers/net/ethernet/8390/Makefile and drivers/scsi/Makefile) won't each static symbol be part each one? What about when they are modules? > > in previous one why not do: > > > > CONFIG_FSL_COMMON += fsl-edma-common.o > > CONFIG_FSL_EDMA += fsl-edma.o > > CONFIG_MCF_EDMA += mcf-edma.o > > > > and you select CONFIG_FSL_COMMON in both FSL and MCF Kconfig? > > That's what he had originally, until I suggested to do the above, as > nothing else > needed the CONFIG_FSL_COMMON symbol. Hmmm, okay what are we gaining from this approach? -- ~Vinod -- To unsubscribe from this list: send the line "unsubscribe dmaengine" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
