On 06/11/2018 12:37 PM, Sinan Kaya wrote: > On 6/11/2018 3:30 PM, Dave Jiang wrote: >> + /* set the completion address register again */ >> + writel(((u64)ioat_chan->completion_dma) & 0x00000000FFFFFFFF, >> + ioat_chan->reg_base + IOAT_CHANCMP_OFFSET_LOW); >> + writel(((u64)ioat_chan->completion_dma) >> 32, >> + ioat_chan->reg_base + IOAT_CHANCMP_OFFSET_HIGH); > > You could have used lower_32_bits() and upper_32_bits() macros here. > I just copy and pasted legacy code from somewhere else in the driver. I can update. -- To unsubscribe from this list: send the line "unsubscribe dmaengine" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
