On 04/10/17 00:58, Dmitry Osipenko wrote: > Document DT binding for the NVIDIA Tegra AHB DMA controller that presents > on Tegra20/30 SoC's. > > Signed-off-by: Dmitry Osipenko <digetx@xxxxxxxxx> > --- > .../bindings/dma/nvidia,tegra20-ahbdma.txt | 23 +++++++++ > include/dt-bindings/dma/tegra-ahb-dma.h | 56 ++++++++++++++++++++++ > 2 files changed, 79 insertions(+) > create mode 100644 Documentation/devicetree/bindings/dma/nvidia,tegra20-ahbdma.txt > create mode 100644 include/dt-bindings/dma/tegra-ahb-dma.h > > diff --git a/Documentation/devicetree/bindings/dma/nvidia,tegra20-ahbdma.txt b/Documentation/devicetree/bindings/dma/nvidia,tegra20-ahbdma.txt > new file mode 100644 > index 000000000000..9fa393766930 > --- /dev/null > +++ b/Documentation/devicetree/bindings/dma/nvidia,tegra20-ahbdma.txt > @@ -0,0 +1,23 @@ > +* NVIDIA Tegra AHB DMA controller > + > +Required properties: > +- compatible: Must be "nvidia,tegra20-ahbdma" Typically, we have a list here indicating what the compatible string should be for the supported devices. So maybe we want something like ... - compatible : Should contain one of the following: - "nvidia,tegra20-ahbdma": for Tegra20 - "nvidia,tegra30-ahbdma", "nvidia,tegra20-ahbdma": for Tegra30 Please note that even thought the driver may only currently define the compatible string "nvidia,tegra20-ahbdma", adding "nvidia,tegra30-ahbdma" in the dts for Tegra30 is good practice if a bug/difference is found later on. Cheers Jon -- nvpublic -- To unsubscribe from this list: send the line "unsubscribe dmaengine" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html