On Tue, Aug 01, 2017 at 09:32:50AM +0000, Pierre Yves MORDRET wrote: > > > On 07/31/2017 02:31 PM, Vinod Koul wrote: > > On Wed, Jul 26, 2017 at 07:38:02AM +0000, Pierre Yves MORDRET wrote: > >>>>>> + > >>>>>> +#ifndef __DMA_STM32_DMAMUX_H > >>>>>> +#define __DMA_STM32_DMAMUX_H > >>>>>> + > >>>>>> +#if defined(CONFIG_STM32_DMAMUX) > >>>>>> +int stm32_dmamux_set_config(struct device *dev, void *route_data, u32 chan_id); > >>>>> > >>>>> Why do we need a custom API in this case? > >>>>> > >>>> > >>>> This API is called by DMA when a slave is requested by client. DMA can work > >>>> without DMAMUX this API has been put in place to configure DMAMUX whether client > >>>> is requesting a DMAMUX Channel instead of a DMA one. > >>> > >>> You mean the dmaengine driver right? > >>> > >> > >> Yes. The API is mainly called by "device_config" through out STM32 DMA Driver > >> when a router is in place for client. > >> Please refer to Patch 4/5 on this set. > > > > Okay am thinking on why this can't be generic..? An optional router config > > callback? > > > > I would have liked to answer there is a callback within engine but unfortunately > I didn't figure out one when I did my router's development. I've looked once > more but again I can't find how to map chanID and request line without custom API. Yes there is no callback for routers but we can add a generic callback here to be used. I added Peter for his comments, isn't that something they need too? -- ~Vinod -- To unsubscribe from this list: send the line "unsubscribe dmaengine" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
