On Fri, Jan 13, 2017 at 02:14:33PM +0200, Andy Shevchenko wrote:
> On Fri, 2017-01-13 at 10:50 +0530, Vinod Koul wrote:
> > On Tue, Jan 10, 2017 at 01:15:33PM +0200, Andy Shevchenko wrote:
> > > On Tue, 2017-01-10 at 10:36 +0530, Vinod Koul wrote:
> > > > On Mon, Jan 02, 2017 at 12:00:48PM +0200, Andy Shevchenko wrote:
> > > >
> > > > > @@ -915,6 +954,7 @@ static int dwc_config(struct dma_chan *chan,
> > > > > struct dma_slave_config *sconfig)
> > > > > {
> > > > > struct dw_dma_chan *dwc = to_dw_dma_chan(chan);
> > > > > struct dma_slave_config *sc = &dwc->dma_sconfig;
> > > > > + struct dw_dma *dw = to_dw_dma(chan->device);
> > > > > /*
> > > > > * Fix sconfig's burst size according to dw_dmac. We
> > > > > need
> > > > > to convert
> > > > > * them as:
> > > > > @@ -922,7 +962,7 @@ static int dwc_config(struct dma_chan *chan,
> > > > > struct dma_slave_config *sconfig)
> > > > > *
> > > > > * NOTE: burst size 2 is not supported by DesignWare
> > > > > controller.
> > > > > */
> > > > > - u32 s = 2;
> > > > > + u32 s = dw->pdata->is_idma32 ? 1 : 2;
> > > >
> > > > why this unexplained change?
> > >
> > > It has been already explained by the line visible in this patch,
> > > i.e.
> > >
> > > * NOTE: burst size 2 is not supported by DesignWare controller.
> >
> > And that is perfect for previous case and now you are adding 1 as
> > well,
> > which I feel should deserve a justification as well
>
> Okay, I would add it in v4.
> Please, review the rest I would be able to incorporate any changes in
> v4
Sure thing
--
~Vinod
--
To unsubscribe from this list: send the line "unsubscribe dmaengine" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
