On 26/09/16 18:28, Vinod Koul wrote:
> On Mon, Sep 26, 2016 at 10:54:21PM +0530, Vinod Koul wrote:
>> On Fri, Sep 23, 2016 at 10:02:23AM +0100, Jon Hunter wrote:
>>>>
>>>> Yes, I've built a few hundred randconfigs overnight, everything succeeds with
>>>> that now.
>>>
>>> Please note that 'depends on PM && HAVE_CLK' is equivalent to just
>>> 'depends on PM_CLK' and so why not use this? This is what I was
>>> suggesting as an alternative to the fix for patch 26/30 [0].
>>
>> That's true, I am comitting with 'depends on PM_CLK' now.
>>
>> Since the other patch doesn't seem to be required, am dropping that one.
>
> FWIW: here is the diff
>
> @@ -480,10 +480,9 @@ config TEGRA20_APB_DMA
>
> config TEGRA210_ADMA
> bool "NVIDIA Tegra210 ADMA support"
> - depends on ARCH_TEGRA_210_SOC
> + depends on (ARCH_TEGRA_210_SOC && PM_CLK) || (ARM && COMPILE_TEST)
> select DMA_ENGINE
> select DMA_VIRTUAL_CHANNELS
> - select PM_CLK
> help
> Support for the NVIDIA Tegra210 ADMA controller driver. The
> DMA controller has multiple DMA channels and is used to service
I still think that this is going to cause problems because if !PM_CLK
but (ARM && COMPILE_TEST) then the PM_CLK APIs will still be undefined.
I believe I mentioned this before, but I think all we need is ...
config TEGRA210_ADMA
bool "NVIDIA Tegra210 ADMA support"
depends on (ARCH_TEGRA_210_SOC || COMPILE_TEST) && PM_CLK
select DMA_ENGINE
select DMA_VIRTUAL_CHANNELS
help
Support for the NVIDIA Tegra210 ADMA controller driver. The
DMA controller has multiple DMA channels and is used to service
Cheers
Jon
--
nvpublic
--
To unsubscribe from this list: send the line "unsubscribe dmaengine" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
