[PATCH v2 00/30] dmaengine: add COMPILE_TEST to drivers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



We recently had a conversation about me cribbing that some drivers being
hard to compile [1]. Arnd suggested [2] to add COMPILE_TEST to these so
right now. With this I have one ARM config which compiles all drivers.

I used multi_v7 default config and checked the drivers which are not
compiling and starting fixing them. So most of them were pretty fine, few
got warning mostly on bad usage of print specifiers with dma_addr_t and
size_t being major culprits there and few sparse warnings.

While compile testing most of the driver compiled fine on others (i have
used ppc, arm, x86_64, i386, mips) expect the two where we explicitly depends
on ARM, one is omap and second one is tegra. Jz one had issues but I moved
header out of arm, so it worked fine.
They have some API dependency, which we should resolve later..

Please test...

Changes in v2:
 o fold in changes made by Arnd in testing, add two patches for kconfig
   dependencies
 o make driver enabled on COMPILE_TEST and not default them on arch's
 o update pointer cast in s3c24xx
 o remove jz4740 header move and don't including that
 o rename tegra patch titles

FWIW: the patches are in git at:

git://git.kernel.org/pub/scm/linux/kernel/git/vkoul/slave-dma.git
test/compile-fixes_v2

Cc: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
Cc: Jonas Jensen <jonas.jensen@xxxxxxxxx>
Cc: Maxime Ripard <maxime.ripard@xxxxxxxxxxxxxxxxxx>
Cc: Jun Nie <jun.nie@xxxxxxxxxx>
Cc: Jon Hunter <jonathanh@xxxxxxxxxx>
Cc: Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx>
Cc: M'boumba Cedric Madianga <cedric.madianga@xxxxxxxxx>
Cc: Zhangfei Gao <zhangfei.gao@xxxxxxxxxx>
Cc: Qiao Zhou <zhouqiao@xxxxxxxxxxx>
Cc: Peter Ujfalusi <peter.ujfalusi@xxxxxx>
Cc: Russell King <rmk+kernel@xxxxxxxxxxxxxxxx>
Cc: Linus Walleij <linus.walleij@xxxxxxxxxx>
Cc: Lars-Peter Clausen <lars@xxxxxxxxxx>

[1]: https://lists.linuxfoundation.org/pipermail/ksummit-discuss/2016-July/002921.html
[2]: https://lists.linuxfoundation.org/pipermail/ksummit-discuss/2016-July/002997.html


Vinod Koul (30):
  dmaengine: jz4740: remove unused arch header
  dmaengine: jz4740: enable COMPILE_TEST
  dmaengine: jz4780: enable COMPILE_TEST
  dmaengine: jz4780: make jz4780_dma_prep_dma_memcpy static
  dmaengine: coh901318: use correct print specifiers
  dmaengine: coh901318: return ssize_t for coh901318_debugfs_read
  dmaengine: coh901318: fix pointer cast warnings
  dmaengine: coh901318: use NULL for pointer initialization
  dmaengine: coh901318: enable COMPILE_TEST
  dmaengine: sa11x0: use correct print specifiers for dma_addr_t
  dmaengine: sa11x0: use correct print specifiers for u32
  dmaengine: sa11x0: use correct print specifiers for size_t
  dmaengine: sa11x0: enable COMPILE_TEST
  dmaengine: ep93xx: use correct print specifiers for size_t
  dmaengine: ep93xx: don't use variables defined in global scope
  dmaengine: ep93xx: enable COMPILE_TEST
  dmaengine: mmp_tdma: use correct print specifiers for size_t
  dmaengine: mmp_pdma: enable COMPILE_TEST
  dmaengine: mmp_tdma: enable COMPILE_TEST
  dmaengine: stm32-dma: enable COMPILE_TEST
  dmaengine: stm32-dma: make stm32_dma_set_config static
  dmaengine: s3c24xx: use correct print specifiers for size_t
  dmaengine: s3c24xx: fix pointer cast warnings
  dmaengine: s3c24xx: enable COMPILE_TEST
  dmaengine: tegra-adma: enable COMPILE_TEST
  dmaengine: tegra-adma: fix unused-function warnings
  dmaengine: timb-dma: enable COMPILE_TEST
  dmaengine: zxdma: enable COMPILE_TEST
  dmaengine: sun4i: fix kconfig unmet direct dependencies
  dmaengine: moxart: fix kconfig unmet direct dependencies

 drivers/dma/Kconfig                        | 29 +++++++++++++----------------
 drivers/dma/coh901318.c                    | 20 ++++++++++----------
 drivers/dma/coh901318_lli.c                |  4 ++--
 drivers/dma/dma-jz4740.c                   |  2 --
 drivers/dma/dma-jz4780.c                   |  2 +-
 drivers/dma/ep93xx_dma.c                   | 12 ++++++------
 drivers/dma/mmp_tdma.c                     |  2 +-
 drivers/dma/s3c24xx-dma.c                  |  6 +++---
 drivers/dma/sa11x0-dma.c                   | 14 +++++++-------
 drivers/dma/stm32-dma.c                    |  2 +-
 drivers/dma/tegra210-adma.c                |  2 ++
 include/linux/platform_data/dma-mmp_tdma.h |  2 +-
 12 files changed, 47 insertions(+), 50 deletions(-)

-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe dmaengine" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux PCI]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux