Re: [PATCH v2 25/30] dmaengine: tegra-adma: enable COMPILE_TEST

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tuesday, September 20, 2016 2:29:15 PM CEST Vinod Koul wrote:
> To get more coverage, enable COMPILE_TEST for this driver.
> 
> Cc: Jon Hunter <jonathanh@xxxxxxxxxx>
> Signed-off-by: Vinod Koul <vinod.koul@xxxxxxxxx>
> ---
>  drivers/dma/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig
> index 1bf84f246868..835c2ab4268e 100644
> --- a/drivers/dma/Kconfig
> +++ b/drivers/dma/Kconfig
> @@ -482,7 +482,7 @@ config TEGRA20_APB_DMA
>  
>  config TEGRA210_ADMA
>  	bool "NVIDIA Tegra210 ADMA support"
> -	depends on ARCH_TEGRA_210_SOC
> +	depends on ARCH_TEGRA_210_SOC || (ARM && COMPILE_TEST)
>  	select DMA_ENGINE
>  	select DMA_VIRTUAL_CHANNELS
>  	select PM_CLK

I think we have to drop the 'select PM_CLK' here:

warning: (ARM_GIC_PM && TEGRA_ACONNECT && TEGRA210_ADMA) selects PM_CLK which has unmet direct dependencies (PM && HAVE_CLK)
0xA55EBB4C Wed Sep 21 18:31:56 CEST 2016 failed
drivers/base/power/clock_ops.o: In function `pm_clk_create':
clock_ops.c:(.text.pm_clk_create+0x0): undefined reference to `dev_pm_get_subsys_data'
drivers/base/power/clock_ops.o: In function `pm_clk_destroy':
clock_ops.c:(.text.pm_clk_destroy+0xb8): undefined reference to `dev_pm_put_subsys_data'
drivers/base/power/clock_ops.o: In function `pm_clk_notify':
clock_ops.c:(.text.pm_clk_notify+0x44): undefined reference to `dev_pm_get_subsys_data'
/git/arm-soc/Makefile:972: recipe for target 'vmlinux' failed

Basically you can never 'select' that symbol unless it's
already enabled, so there is no harm in removing that line.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe dmaengine" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux PCI]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux