On Fri, Sep 16, 2016 at 08:21:13PM +0530, Vinod Koul wrote: > On Fri, Sep 16, 2016 at 02:56:32PM +0200, Krzysztof Kozlowski wrote: > > On 09/15/2016 07:34 PM, Vinod Koul wrote: > > > To get more coverage, enable COMPILE_TEST for this driver. > > > > > > Cc: Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx> > > > Signed-off-by: Vinod Koul <vinod.koul@xxxxxxxxx> > > > --- > > > drivers/dma/Kconfig | 4 ++-- > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig > > > index 82d6e374d82f..60341185a6b9 100644 > > > --- a/drivers/dma/Kconfig > > > +++ b/drivers/dma/Kconfig > > > @@ -451,8 +451,8 @@ config STM32_DMA > > > here. > > > > > > config S3C24XX_DMAC > > > - bool "Samsung S3C24XX DMA support" > > > - depends on ARCH_S3C24XX > > > + bool "Samsung S3C24XX DMA support" if COMPILE_TEST && !ARCH_S3C24XX > > > + default ARCH_S3C24XX > > > > This is not equivalent to previous code. > > Yeah it is not and enables the driver by default. My bad, I should have > explicitly mentioned this. > > My though was to indeed enable them by default, do you see any issues with > that? I don't see any particular problems with that. Default value is just a hint and can be overridden. I think however that such change should be in separate patch. One thing is adding compile-test and second is turning this on for our defconfigs. They might have different outcomes (failing of various archs/configs for the first, failing of our defconfigs for the latter). Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe dmaengine" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
