On 09/15/2016 07:34 PM, Vinod Koul wrote: > To get more coverage, enable COMPILE_TEST for this driver. > > Cc: Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx> > Signed-off-by: Vinod Koul <vinod.koul@xxxxxxxxx> > --- > drivers/dma/Kconfig | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig > index 82d6e374d82f..60341185a6b9 100644 > --- a/drivers/dma/Kconfig > +++ b/drivers/dma/Kconfig > @@ -451,8 +451,8 @@ config STM32_DMA > here. > > config S3C24XX_DMAC > - bool "Samsung S3C24XX DMA support" > - depends on ARCH_S3C24XX > + bool "Samsung S3C24XX DMA support" if COMPILE_TEST && !ARCH_S3C24XX > + default ARCH_S3C24XX This is not equivalent to previous code. I think it should be: bool "Samsung S3C24XX DMA support" if COMPILE_TEST depends on ARCH_S3C24XX || COMPILE_TEST 1. This way we do not enable it by default on the architecture (it wasn't enabled so far), 2. The option is visible on compile test, 3. The runtime dependency is preserved. Best regards, Krzysztof > select DMA_ENGINE > select DMA_VIRTUAL_CHANNELS > help > -- To unsubscribe from this list: send the line "unsubscribe dmaengine" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
