> -----Original Message----- > From: dmaengine-owner@xxxxxxxxxxxxxxx [mailto:dmaengine-owner@xxxxxxxxxxxxxxx] On Behalf Of Jiang, Dave > Sent: Tuesday, July 19, 2016 11:20 AM > To: Lars-Peter Clausen <lars@xxxxxxxxxx>; Koul, Vinod <vinod.koul@xxxxxxxxx> > Cc: dmaengine@xxxxxxxxxxxxxxx; Williams, Dan J <dan.j.williams@xxxxxxxxx>; Nicolas Ferre <nicolas.ferre@xxxxxxxxx>; > laurent.pinchart@xxxxxxxxxxxxxxxx > Subject: RE: [PATCH v3 02/41] dmaengine: at_hdmac: convert callback to helper function > > > -----Original Message----- > > From: Lars-Peter Clausen [mailto:lars@xxxxxxxxxx] > > Sent: Tuesday, July 19, 2016 11:16 AM > > To: Jiang, Dave <dave.jiang@xxxxxxxxx>; Koul, Vinod <vinod.koul@xxxxxxxxx> > > Cc: dmaengine@xxxxxxxxxxxxxxx; Williams, Dan J <dan.j.williams@xxxxxxxxx>; Nicolas Ferre <nicolas.ferre@xxxxxxxxx>; > > laurent.pinchart@xxxxxxxxxxxxxxxx > > Subject: Re: [PATCH v3 02/41] dmaengine: at_hdmac: convert callback to helper function > > > > On 07/18/2016 11:47 PM, Dave Jiang wrote: > > > Convert driver to use the new helper function for callback > > > > I'd still like to see a proper commit message for the transformation > > patches. You know what this is about, I know what this is about, somebody > > reading the log in 2-3 years will have no idea. > > Ok I'll fix that up. You want a more verbose commit message for patch 1/41 and 36/41 for the two transformation patches and not all the drivers patches correct? Just want to clarify. > > > > > > /*-- IRQ & Tasklet ---------------------------------------------------*/ > > > diff --git a/drivers/dma/dmaengine.h b/drivers/dma/dmaengine.h > > > index 6fb5edc..e64d27a 100644 > > > --- a/drivers/dma/dmaengine.h > > > +++ b/drivers/dma/dmaengine.h > > > @@ -116,4 +116,10 @@ dmaengine_desc_get_callback_invoke(struct dma_async_tx_descriptor *tx, > > > dmaengine_desc_callback_invoke(cb, result); > > > } > > > > > > +static inline bool > > > +dmaengine_desc_callback_valid(struct dmaengine_desc_callback *cb) > > > +{ > > > + return (cb->callback) ? true : false; > > > +} > > > > This should be part of patch 1. > > Uck. stgit user error. Will fix. > �{.n�+�������+%��lzwm��b�맲��r��yٚzx"�觶 > ��ܨ}���Ơz�&j:+v��� ����zZ+��+zf���h���~����i���z� �w���?����&�)ߢf ��.n��������+%������w��{.n��������)�)�� jg��� �����ݢj����G���� ���j:+v���w�m������w�������h�����٥
