On 07/18/2016 11:47 PM, Dave Jiang wrote: > Convert driver to use the new helper function for callback I'd still like to see a proper commit message for the transformation patches. You know what this is about, I know what this is about, somebody reading the log in 2-3 years will have no idea. > /*-- IRQ & Tasklet ---------------------------------------------------*/ > diff --git a/drivers/dma/dmaengine.h b/drivers/dma/dmaengine.h > index 6fb5edc..e64d27a 100644 > --- a/drivers/dma/dmaengine.h > +++ b/drivers/dma/dmaengine.h > @@ -116,4 +116,10 @@ dmaengine_desc_get_callback_invoke(struct dma_async_tx_descriptor *tx, > dmaengine_desc_callback_invoke(cb, result); > } > > +static inline bool > +dmaengine_desc_callback_valid(struct dmaengine_desc_callback *cb) > +{ > + return (cb->callback) ? true : false; > +} This should be part of patch 1. -- To unsubscribe from this list: send the line "unsubscribe dmaengine" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html