On Fri, Jul 08, 2016 at 10:52:15AM +0200, Daniel Mack wrote: > Hi Vinod, > > On 07/05/2016 04:54 PM, Vinod Koul wrote: > > dmaengine device should explicitly call devm_free_irq() when using > > devm_reqister_irq(). > > You mean devm_request_irq(), right? Yes, thats for spotting :) > The whole point about these devm_* > functions is that the resources claimed by them are automatically freed > on driver removal, so I wonder why it is necessary to call them > explicitly for this driver. What am I missing? spurious irq's! I do not advise using devm_register_irq() and if someone does, I always ask them to explicitly freeup or disable in the .remove. -- ~Vinod -- To unsubscribe from this list: send the line "unsubscribe dmaengine" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
