[PATCH 00/32] dmaengine: cleanups...

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This series attempts to do few cleanup for drivers. My aim was to fix irq
cleanup but on the way found few more things to be fixed as well.
 o explicitly freeup irq: Many drivers nowadays use devm variant for
   requesting irq, which is fine from cleanup POV, but on remove you leave irq
   enabled and able to fire. This can lead to nasty races, so better idea is
   to explicitly freeup.
 o same situation is with tasklets. They need to be killed before we exit,
   so that has been fixed too
 o while at it noticed few drivers still set .owner, removed them as well.
 o also fixed few sparse complaints

Please do test, I have tried to copy folks involved with these drivers and
sometimes it was bit tougher to find.

Compiling these was a challenge, I though arm-multi should help compiling
all the stuff, but not everything was easy. Even some of the defconfigs were
bit painful to work with, esp the pxa and s3c stuff.

This series is also pushed to my dmaengine clone at kernel.org as kbuild bot
runs tests on this clone.
https://git.kernel.org/cgit/linux/kernel/git/vkoul/slave-dma.git/log/?h=dmaengine_cleanups

No issues reported by that so far, please verify

Cc: Robert Jarzmik <robert.jarzmik@xxxxxxx>
Cc: Xuelin Shi <xuelin.shi@xxxxxxxxxxxxx>
Cc: Linus Walleij <linus.walleij@xxxxxxxxxx>
Cc: Sinan Kaya <okaya@xxxxxxxxxxxxxx>
Cc: Barry Song <Baohua.Song@xxxxxxx>
Cc: Krzysztof Kozlowski <k.kozlowski.k@xxxxxxxxx>
Cc: Robert Jarzmik <robert.jarzmik@xxxxxxx>
Cc: Jassi Brar <jassisinghbrar@xxxxxxxxx>
Cc: Peter Ujfalusi <peter.ujfalusi@xxxxxx>
Cc: Mario Six <mario.six@xxxxxxxx>
Cc: Guennadi Liakhovetski <g.liakhovetski+renesas@xxxxxxxxx>
Cc: Jonas Jensen <jonas.jensen@xxxxxxxxx>
Cc: Qiao Zhou <zhouqiao@xxxxxxxxxxx>
Cc: Zhangfei Gao <zhangfei.gao@xxxxxxxxxx>
Cc: Daniel Mack <zonque@xxxxxxxxx>
Cc: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>
Cc: Fabio Estevam <fabio.estevam@xxxxxxxxxxxxx>
Cc: Jingchang Lu <b35083@xxxxxxxxxxxxx>
Cc: Peter Griffin <peter.griffin@xxxxxxxxxx>
Cc: Lars-Peter Clausen <lars@xxxxxxxxxx>
Cc: Peter Griffin <peter.griffin@xxxxxxxxxx>

Vinod Koul (32):
  dmaengine: coh901318: explicitly freeup irq
  dmaengine: coh901318: kill the tasklets upon exit
  dmaengine: coh901318: statify symbols
  dmaengine: edma: explicitly freeup irq
  dmaengine: edma: kill the tasklets upon exit
  dmaengine: fsl-edma: explicitly freeup irq
  dmaengine: fsl_raid: kill the tasklets upon exit
  dmaengine: fsl_raid: fix size_t print specifiers
  dmaengine: jz4740: kill the tasklets upon exit
  dmaengine: fsl-edma: kill the tasklets upon exit
  dmaengine: imx-dma: explicitly freeup irq
  dmaengine: imx-dma: kill the tasklets upon exit
  dmaengine: imx-dma: fix coding style issue
  dmaengine: imx-sdma: explicitly freeup irq
  dmaengine: k3dma: explicitly freeup irq
  dmaengine: mmp_pdma: explicitly freeup irq
  dmaengine: mmp_tdma: statify symbols
  dmaengine: moxart-dma: explicitly freeup irq
  dmaengine: nbpfaxi: explicitly freeup irq
  dmaengine: nbpfaxi: kill the tasklets upon exit
  dmaengine: mpc512x: kill the tasklets upon exit
  dmaengine: omap-dma: explicitly freeup irq
  dmaengine: pl330: explicitly freeup irq
  dmaengine: pxa_dm: explicitly freeup irq
  dmaengine: s3c24xx: explicitly freeup irq
  dmaengine: s3c24xx: kill the tasklets upon exit
  dmaengine: sirf-dma: kill the tasklets upon exit
  dmaengine: txx9dmac: explicitly freeup irq
  dmaengine: qcom_hidma: kill the tasklets upon exit
  dmaengine: coh901318: remove owner assignment
  dmaengine: fsl_raid: remove owner assignment
  dmaengine: pxa_dma: remove owner assignment

 drivers/dma/coh901318.c   | 30 ++++++++++++++++++++++++++----
 drivers/dma/dma-jz4740.c  | 14 ++++++++++++++
 drivers/dma/edma.c        | 21 +++++++++++++++++++++
 drivers/dma/fsl-edma.c    | 24 ++++++++++++++++++++++++
 drivers/dma/fsl_raid.c    |  9 +++++----
 drivers/dma/imx-dma.c     | 31 ++++++++++++++++++++++++++++++-
 drivers/dma/imx-sdma.c    |  4 ++++
 drivers/dma/k3dma.c       |  5 +++++
 drivers/dma/mmp_pdma.c    | 17 +++++++++++++++++
 drivers/dma/mmp_tdma.c    |  4 ++--
 drivers/dma/moxart-dma.c  |  4 ++++
 drivers/dma/mpc512x_dma.c |  1 +
 drivers/dma/nbpfaxi.c     | 13 +++++++++++++
 drivers/dma/omap-dma.c    |  4 ++++
 drivers/dma/pl330.c       |  6 ++++++
 drivers/dma/pxa_dma.c     | 23 ++++++++++++++++++++++-
 drivers/dma/qcom/hidma.c  |  1 +
 drivers/dma/s3c24xx-dma.c | 18 +++++++++++++++++-
 drivers/dma/sirf-dma.c    |  1 +
 drivers/dma/txx9dmac.c    |  9 +++++++--
 20 files changed, 224 insertions(+), 15 deletions(-)

-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe dmaengine" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux PCI]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux