Re: [PATCH 01/32] dmaengine: coh901318: explicitly freeup irq

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jul 5, 2016 at 4:54 PM, Vinod Koul <vinod.koul@xxxxxxxxx> wrote:

> dmaengine device should explicitly call devm_free_irq() when using
> devm_reqister_irq().
>
> The irq is still ON when devices remove is executed and irq should be
> quiesced before remove is completed.
>
> Signed-off-by: Vinod Koul <vinod.koul@xxxxxxxxx>
> Cc: Linus Walleij <linus.walleij@xxxxxxxxxx>

Acked-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

This patch makes me very uneasy. A spurious IRQ can always happen, so
Isn't this problem existing on more or less the .remove() path of 95%
if all drivers
using devm_request_irq() in the entire kernel?

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe dmaengine" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux PCI]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux