Re: [PATCH] dma: imx-sdma: Remove redundant assignment

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello,

On Fri, Jul 01, 2016 at 10:10:24PM +0300, Alexander Shiyan wrote:
> >Вторник, 28 июня 2016, 6:36 +03:00 от Vinod Koul <vinod.koul@xxxxxxxxx>:
> >
> >On Sat, Jun 25, 2016 at 08:33:59AM +0300, Alexander Shiyan wrote:
> >> Signed-off-by: Alexander Shiyan < shc_work@xxxxxxx >
> >
> >No changelog? Please do explain why this is redundant...
> 
> I can not even imagine what it would be possible to add in the description,
> in addition to the subject.
> The patch consists of one line which speaks for itself.
> Such change really need to explain?

Something like:

	An expression

		v |= v

	with v being an unsigned int has no effect. Removing it doesn't
	change the generated code (tested with gcc 5.1).

would be great.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
--
To unsubscribe from this list: send the line "unsubscribe dmaengine" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux PCI]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux