Re: [PATCH] dma: imx-sdma: Remove redundant assignment

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



>Вторник, 28 июня 2016, 6:36 +03:00 от Vinod Koul <vinod.koul@xxxxxxxxx>:
>
>On Sat, Jun 25, 2016 at 08:33:59AM +0300, Alexander Shiyan wrote:
>> Signed-off-by: Alexander Shiyan < shc_work@xxxxxxx >
>
>No changelog? Please do explain why this is redundant...

I can not even imagine what it would be possible to add in the description,
in addition to the subject.
The patch consists of one line which speaks for itself.
Such change really need to explain?

>> ---
>>  drivers/dma/imx-sdma.c | 2 --
>>  1 file changed, 2 deletions(-)
>> 
>> diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c
>> index 0f6fd42..409d858 100644
>> --- a/drivers/dma/imx-sdma.c
>> +++ b/drivers/dma/imx-sdma.c
>> @@ -999,8 +999,6 @@ static int sdma_config_channel(struct dma_chan *chan)
>>  } else
>>  __set_bit(sdmac->event_id0, sdmac->event_mask);
>> 
>> -/* Watermark Level */
>> -sdmac->watermark_level |= sdmac->watermark_level;
>>  /* Address */
>>  sdmac->shp_addr = sdmac->per_address;
>>  sdmac->per_addr = sdmac->per_address2;

---

��.n��������+%������w��{.n��������)�)��jg��������ݢj����G�������j:+v���w�m������w�������h�����٥




[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux PCI]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux