On Tue, Nov 24, 2015 at 02:16:55PM -0600, Rob Herring wrote:
> On Tue, Nov 24, 2015 at 11:20:41AM +0900, Simon Horman wrote:
> > In general Renesas hardware is not documented to the extent where the
> > relationship between IP blocks on different SoCs can be assumed although
> > they may appear to operate the same way. Furthermore the documentation
> > typically does not specify a version for individual IP blocks. For these
> > reasons a convention of using the SoC name in place of a version and
> > providing SoC-specific compat strings has been adopted.
> >
> > Although not universally liked this convention is used in the bindings for
> > most drivers for Renesas hardware. The purpose of this patch is to
> > update the Renesas USB DMA Controller driver to follow this convention.
> >
> > Cc: devicetree@xxxxxxxxxxxxxxx
> > Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx>
> > Signed-off-by: Simon Horman <horms+renesas@xxxxxxxxxxxx>
> >
> > ---
> > * r8a7792 (R-Car V2H) is omitted as my reading of the documentation
> > is that Renesas USB-DMAC does not exist on that SoC
> > * r8a7795 (R-Car H2) is omitted as its unclear to me on the compatibility
> > of USB-DMAC that SoC
> >
> > * Once this has been merged I intend to provide follow-up patches
> > to use these new compat strings in the relevant dtsi files.
> > ---
> > Documentation/devicetree/bindings/dma/renesas,usb-dmac.txt | 9 +++++++--
> > 1 file changed, 7 insertions(+), 2 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/dma/renesas,usb-dmac.txt b/Documentation/devicetree/bindings/dma/renesas,usb-dmac.txt
> > index 040f365954cc..3bb624e10615 100644
> > --- a/Documentation/devicetree/bindings/dma/renesas,usb-dmac.txt
> > +++ b/Documentation/devicetree/bindings/dma/renesas,usb-dmac.txt
> > @@ -1,7 +1,12 @@
> > * Renesas USB DMA Controller Device Tree bindings
> >
> > Required Properties:
> > -- compatible: must contain "renesas,usb-dmac"
> > +- compatible: "renesas,usb-dmac-<soctype>", "renesas,usb-dmac" as fallback.
> > + Examples with soctypes are:
> > + - "renesas,usb-dmac-r8a7790" (R-Car H2)
> > + - "renesas,usb-dmac-r8a7791" (R-Car M2-W)
> > + - "renesas,usb-dmac-r8a7793" (R-Car M2-N)
> > + - "renesas,usb-dmac-r8a7794" (R-Car E2)
>
> Weren't you changing the order of SoC and block names on new bindings?
Could you clarify what the desired order is?
My intention is for these bindings to use the preferred order.
> Either way:
>
> Acked-by: Rob Herring <robh@xxxxxxxxxx>
>
> Rob
>
> > - reg: base address and length of the registers block for the DMAC
> > - interrupts: interrupt specifiers for the DMAC, one for each entry in
> > interrupt-names.
> > @@ -15,7 +20,7 @@ Required Properties:
> > Example: R8A7790 (R-Car H2) USB-DMACs
> >
> > usb_dmac0: dma-controller@e65a0000 {
> > - compatible = "renesas,usb-dmac";
> > + compatible = "renesas,usb-dmac-r8a7790", "renesas,usb-dmac";
> > reg = <0 0xe65a0000 0 0x100>;
> > interrupts = <0 109 IRQ_TYPE_LEVEL_HIGH
> > 0 109 IRQ_TYPE_LEVEL_HIGH>;
> > --
> > 2.1.4
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe devicetree" in
> > the body of a message to majordomo@xxxxxxxxxxxxxxx
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe dmaengine" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
