Re: [PATCH v4 3/3] dmaengine: dw: some Intel devices has no memcpy support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2015-10-28 at 15:31 +0900, Vinod Koul wrote:
> On Tue, Oct 27, 2015 at 10:26:11AM +0200, Andy Shevchenko wrote:
> > On Tue, 2015-10-27 at 10:01 +0900, Vinod Koul wrote:
> > > On Tue, Oct 13, 2015 at 08:09:19PM +0300, Andy Shevchenko wrote:
> > > > Provide a flag to choose if the device does support memory-to-
> > > > memory transfers.
> > > > At least this is not true for iDMA32 controller that might be
> > > > supported in the
> > > > future. Besides that Intel BayTrail and Braswell users should
> > > > not
> > > > try this
> > > > feature due to HW specific behaviour.
> > > > 
> > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.c
> > > > om>
> > > > ---
> > > >  drivers/dma/dw/core.c                | 6 +++++-
> > > >  include/linux/platform_data/dma-dw.h | 2 ++
> > > >  2 files changed, 7 insertions(+), 1 deletion(-)
> > > > 
> > > > diff --git a/drivers/dma/dw/core.c b/drivers/dma/dw/core.c
> > > > index 41b7592..7067b6d 100644
> > > > --- a/drivers/dma/dw/core.c
> > > > +++ b/drivers/dma/dw/core.c
> > > > @@ -1541,6 +1541,7 @@ int dw_dma_probe(struct dw_dma_chip
> > > > *chip,
> > > > struct dw_dma_platform_data *pdata)
> > > >  
> > > >  		/* Fill platform data with the default values
> > > > */
> > > >  		pdata->is_private = true;
> > > > +		pdata->is_memcpy = true;
> > > 
> > > But you are setting this always, so what is the point of this
> > > patch
> > 
> > Yes, this setting works for all cases where we are using auto
> > configuration. Otherwise it will come from platform data (see the
> > patches 1 and 2).
> 
> So do you expect BYT and BSW to use pdata and not autcfg? I thought
> they
> should use autcfg and based on your above comment expected it to be
> set to
> false...

There are two cases: ACPI) feature should be not used; PCI) it's okay
to use it.

Platform data is added only for ACPI BYT/BSW cases (There are also HSW
and BDW, where feature didn't advertised anyway, though it works in
both cases).

-- 
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Intel Finland Oy

--
To unsubscribe from this list: send the line "unsubscribe dmaengine" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux PCI]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux