On Tue, 2015-10-27 at 10:01 +0900, Vinod Koul wrote: > On Tue, Oct 13, 2015 at 08:09:19PM +0300, Andy Shevchenko wrote: > > Provide a flag to choose if the device does support memory-to- > > memory transfers. > > At least this is not true for iDMA32 controller that might be > > supported in the > > future. Besides that Intel BayTrail and Braswell users should not > > try this > > feature due to HW specific behaviour. > > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> > > --- > > drivers/dma/dw/core.c | 6 +++++- > > include/linux/platform_data/dma-dw.h | 2 ++ > > 2 files changed, 7 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/dma/dw/core.c b/drivers/dma/dw/core.c > > index 41b7592..7067b6d 100644 > > --- a/drivers/dma/dw/core.c > > +++ b/drivers/dma/dw/core.c > > @@ -1541,6 +1541,7 @@ int dw_dma_probe(struct dw_dma_chip *chip, > > struct dw_dma_platform_data *pdata) > > > > /* Fill platform data with the default values */ > > pdata->is_private = true; > > + pdata->is_memcpy = true; > > But you are setting this always, so what is the point of this patch Yes, this setting works for all cases where we are using auto configuration. Otherwise it will come from platform data (see the patches 1 and 2). -- Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> Intel Finland Oy -- To unsubscribe from this list: send the line "unsubscribe dmaengine" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html