On Wednesday 15 July 2015 10:29:55 Yao Yuan wrote: > Hi Arnd, > > Thanks for your review. > And can you give me more information? > In my opinion, The fsl_edma_pm_state will just be used when CONFIG_PM support. So why not use the #ifdefs to remove the > unnecessary code? Since the PM will not be selected in many use cases. I would consider code readability more important than saving a few instructions, and the #ifdef interrupts the reading flow. Another aspect is that the compiler does not produce warnings for incorrect code in an #ifdef, so we try to use e.g. 'if (IS_ENABLED(CONFIG_FOO))' instead of '#ifdef CONFIG_FOO' wherever possible. Arnd -- To unsubscribe from this list: send the line "unsubscribe dmaengine" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
