Hi Arnd, Thanks for your review. And can you give me more information? In my opinion, The fsl_edma_pm_state will just be used when CONFIG_PM support. So why not use the #ifdefs to remove the unnecessary code? Since the PM will not be selected in many use cases. Thanks. Best Regards, Yuan Yao > -----Original Message----- > From: Arnd Bergmann [mailto:arnd@xxxxxxxx] > Sent: Wednesday, July 15, 2015 5:57 PM > To: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx > Cc: Yuan Yao-B46683; vinod.koul@xxxxxxxxx; stefan@xxxxxxxx; > dmaengine@xxxxxxxxxxxxxxx; dan.j.williams@xxxxxxxxx; linux- > kernel@xxxxxxxxxxxxxxx > Subject: Re: [PATCH] dmaengine: fsl-edma: add PM suspend/resume support > > On Wednesday 15 July 2015 17:32:58 Yuan Yao wrote: > > +#ifdef CONFIG_PM > > +enum fsl_edma_pm_state { > > + RUNNING = 0, > > + SUSPENDED, > > +}; > > +#endif > > > > struct fsl_edma_hw_tcd { > > > > The #ifdefs here seem unnecessary, at least most of them, better just do this > all unconditionally. > > Arnd -- To unsubscribe from this list: send the line "unsubscribe dmaengine" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
