On Thursday 22 January 2015 01:24:04 Kuninori Morimoto wrote: > Hi Arnd, again > > > > > Thank you for pointing it. > > > > But, unfortunately, this FSI driver is not used from DT. > > > > (It is supporting DT probe, but no one use it) > > > > So, it is assuming that dst_addr/src_addr fields are come > > > > from platform data. > > > > > > I see. My patch would still be correct, right? > > > > > > I think the way that Guennadi Liakhovetski started the conversion of > > > shmobile dmaengine drivers, each slave driver either uses a custom > > > filter function that relies on the platform data and will not work > > > with DT, or it uses dma_request_slave_channel_compat() which will > > > work on both, and then uses dmaengine_slave_config() to pass the > > > extra settings. This driver is the one exception you have since it > > > uses a combination of the two approaches. > > > > I understand. > > will fix in v3 patch > > I understand, but it is different feature patch. > I want to focus to "remove slave_id" on this patch series. > And, I send fixup above dst_addr/src_addr in other patch. > Is this OK ? Yes, good idea. I was mentioning it mainly so it does not get lost, but it is unrelated as you say. Arnd -- To unsubscribe from this list: send the line "unsubscribe dmaengine" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
