Re: [PATCH 7/8 v2] ASoC: fsi: remove slave_id settings for DMAEngine

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Arnd

> > Thank you for pointing it.
> > But, unfortunately, this FSI driver is not used from DT.
> > (It is supporting DT probe, but no one use it)
> > So, it is assuming that dst_addr/src_addr fields are come
> > from platform data.
> 
> I see. My patch would still be correct, right?
> 
> I think the way that Guennadi Liakhovetski started the conversion of
> shmobile dmaengine drivers, each slave driver either uses a custom
> filter function that relies on the platform data and will not work
> with DT, or it uses dma_request_slave_channel_compat() which will
> work on both, and then uses dmaengine_slave_config() to pass the
> extra settings. This driver is the one exception you have since it
> uses a combination of the two approaches.

I understand.
will fix in v3 patch

Best regards
---
Kuninori Morimoto
--
To unsubscribe from this list: send the line "unsubscribe dmaengine" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux PCI]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux