Re: [PATCH 2/8 v2] mmc: sh_mmcif: remove slave_id settings for DMAEngine

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Ulf

> > @@ -397,13 +397,13 @@ sh_mmcif_request_dma_one(struct sh_mmcif_host *host,
> >         dma_cap_set(DMA_SLAVE, mask);
> >
> >         if (pdata)
> > -               slave_id = direction == DMA_MEM_TO_DEV
> > -                        ? pdata->slave_id_tx : pdata->slave_id_rx;
> > +               slave_data = direction == DMA_MEM_TO_DEV
> > +                       ? (void *)pdata->slave_id_tx : (void *)pdata->slave_id_rx;
> >         else
> 
> You may get rid of this else clause. Just assign slave_data to NULL
> while declaring it above.
> 
> > -               slave_id = 0;
> > +               slave_data = 0;

Thank you
Will fix in v2 patch

Best regards
---
Kuninori Morimoto
--
To unsubscribe from this list: send the line "unsubscribe dmaengine" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux PCI]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux