Re: [PATCH v3] dmaengine:: rcar-hpbdma: add dma_dev->directions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Laurent

> > @@ -595,6 +597,10 @@ static int hpb_dmae_probe(struct platform_device *pdev)
> > 
> >  	dma_cap_set(DMA_MEMCPY, dma_dev->cap_mask);
> >  	dma_cap_set(DMA_SLAVE, dma_dev->cap_mask);
> > +	dma_dev->src_addr_widths = widths;
> > +	dma_dev->dst_addr_widths = widths;
> > +	dma_dev->directions = BIT(DMA_MEM_TO_DEV) | BIT(DMA_DEV_TO_MEM);
> > +	dma_dev->residue_granularity = DMA_RESIDUE_GRANULARITY_BURST;
> 
> The driver doesn't seem to support residue reporting at all, shouldn't 
> residue_granularity be set to DMA_RESIDUE_GRANULARITY_DESCRIPTOR then ?

Thank you for pointing it.
will fix in v4 patch

Best regards
---
Kuninori Morimoto
--
To unsubscribe from this list: send the line "unsubscribe dmaengine" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux PCI]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux