On Thu, Jan 08, 2015 at 10:58:39AM +0100, Lars-Peter Clausen wrote: > On 01/08/2015 06:28 AM, Kevin Hao wrote: > >On Wed, Jan 07, 2015 at 03:23:24PM +0100, Lars-Peter Clausen wrote: > >>On 01/07/2015 01:57 PM, Kevin Hao wrote: > >>[...] > >>>+ fdev->common.src_addr_widths = FSL_DMA_BUSWIDTHS; > >>>+ fdev->common.dst_addr_widths = FSL_DMA_BUSWIDTHS; > >>>+ fdev->common.directions = BIT(DMA_DEV_TO_MEM) | BIT(DMA_MEM_TO_DEV); > >> > >>Please also set residue_granularity. > > > >In the current fsldma driver, the residue reporting is not supported. So using > >the default setting (DMA_RESIDUE_GRANULARITY_DESCRIPTOR) seems right to me. > >Why do we still need to explicitly set residue_granularity? Did I miss > >something? > > Setting it makes it explicit that this is the granularity that is supported > by the driver and not simply has been overlooked setting the property. OK, I will set the residue_granularity to DMA_RESIDUE_GRANULARITY_DESCRIPTOR explicitly. The v2 coming soon. Thanks, Kevin
Attachment:
pgpTHk0F9OfGG.pgp
Description: PGP signature
