Re: [PATCH 1/2] dmaengine: fsldma: declare slave capabilities for the generic code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 01/08/2015 06:28 AM, Kevin Hao wrote:
On Wed, Jan 07, 2015 at 03:23:24PM +0100, Lars-Peter Clausen wrote:
On 01/07/2015 01:57 PM, Kevin Hao wrote:
[...]
+	fdev->common.src_addr_widths = FSL_DMA_BUSWIDTHS;
+	fdev->common.dst_addr_widths = FSL_DMA_BUSWIDTHS;
+	fdev->common.directions = BIT(DMA_DEV_TO_MEM) | BIT(DMA_MEM_TO_DEV);

Please also set residue_granularity.

In the current fsldma driver, the residue reporting is not supported. So using
the default setting (DMA_RESIDUE_GRANULARITY_DESCRIPTOR) seems right to me.
Why do we still need to explicitly set residue_granularity? Did I miss
something?

Setting it makes it explicit that this is the granularity that is supported by the driver and not simply has been overlooked setting the property.

--
To unsubscribe from this list: send the line "unsubscribe dmaengine" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux PCI]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux