Re: [PATCH 3/3] dma: rcar-audmapp: add DT support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Geert

> > +Required properties:
> > +- dmas:                a list of <[DMA multiplexer phandle] [SRS/DRS value]> pairs,
> > +               where SRS/DRS values are fixed handles, specified in the SoC
> > +               manual as the value that would be written into the PDMACHCR.
> 
> I think this wording is a little bit confusing.
> It's not the "value that would be written into the PDMACHCR", but the
> high 16-bit
> part of that value, cfr. the example and the actual code below.
> 
> An alternative way of saying this could be "SRS << 8 | DRS", which clearly
> shows how to combine SRS and DRS.
> Unlike the docs for SYS-DMAC, which contains a table of combined MID/RID
> values,  the Audio DMAC-peri-peri docs contain 2 separate tables for SRS and
> DRS values, so the DTS writer has to combine them manually.

Hmm... indeed
OK, I understand.
I fix it and send patch.

Best regards
---
Kuninori Morimoto
--
To unsubscribe from this list: send the line "unsubscribe dmaengine" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux PCI]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux