Hi Laurent,
On Sat, Jul 19, 2014 at 1:50 AM, Laurent Pinchart
<laurent.pinchart+renesas@xxxxxxxxxxxxxxxx> wrote:
> Separate helpers and drivers in the Kconfig and Makefile to improve
> readability and move the CONFIG_OF dependency from the Makefile to
> Kconfig.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx>
>
> ---
>
> Changes since v1:
>
> - Replace CONFIG_OF with OF in Kconfig
> ---
> drivers/dma/sh/Kconfig | 24 +++++++++++++++++++-----
> drivers/dma/sh/Makefile | 14 +++++++++++---
> 2 files changed, 30 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/dma/sh/Kconfig b/drivers/dma/sh/Kconfig
> index 0f71981..0349125 100644
> --- a/drivers/dma/sh/Kconfig
> +++ b/drivers/dma/sh/Kconfig
> @@ -2,21 +2,39 @@
> # DMA engine configuration for sh
> #
>
> +#
> +# DMA Engine Helpers
> +#
> +
> config SH_DMAE_BASE
> bool "Renesas SuperH DMA Engine support"
> - depends on (SUPERH && SH_DMA) || ARCH_SHMOBILE || COMPILE_TEST
> + depends on SUPERH || ARCH_SHMOBILE || COMPILE_TEST
> + depends on !SUPERH || SH_DMA
> depends on !SH_DMA_API
> default y
> select DMA_ENGINE
> help
> Enable support for the Renesas SuperH DMA controllers.
>
> +#
> +# DMA Controllers
> +#
> +
> config SH_DMAE
> tristate "Renesas SuperH DMAC support"
> depends on SH_DMAE_BASE
> help
> Enable support for the Renesas SuperH DMA controllers.
>
> +if SH_DMAE
> +
> +config SH_DMAE_R8A73A4
> + def_bool y
> + depends on ARCH_R8A73A4
> + depends on OF
> +
> +endif
What's the rationale behind putting this inside an "if/endif" block, instead of
using "depends on"?
BTW, I'm still puzzled by the difference between SH_DMAE_BASE and SH_DMAE,
which have identical help texts.
> +
> config SUDMAC
> tristate "Renesas SUDMAC support"
> depends on SH_DMAE_BASE
> @@ -34,7 +52,3 @@ config RCAR_AUDMAC_PP
> depends on SH_DMAE_BASE
> help
> Enable support for the Renesas R-Car Audio DMAC Peripheral Peripheral controllers.
> -
> -config SHDMA_R8A73A4
> - def_bool y
> - depends on ARCH_R8A73A4 && SH_DMAE != n
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe dmaengine" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
