On 04/11/2014 01:39 AM, Peter Ujfalusi wrote: > On 04/11/2014 01:40 AM, Joel Fernandes wrote: >> On 04/01/2014 08:06 AM, Peter Ujfalusi wrote: >>> We only support DEV_TO_MEM or MEM_TO_DEV directions with edma driver and the >>> check for the direction has been already done in the function calling >>> edma_config_pset(). >>> The error reporting is redundant and also the "else if ()" can be removed. >>> >> >> NAK. Please don't do this. I have been working on MEM_TO_MEM support as >> well so leave it as it is for future. > > Sure. It is still valid to say that the error else {} will never going to > happen since you have the same check in the calling function and they already > filtered the non implemented direction. > That's true. Though the patch removes the else if which would mean more work later ;) > I'll leave this out from v3. Thanks. Regards, -Joel -- To unsubscribe from this list: send the line "unsubscribe dmaengine" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html