On Sat, 2014-02-22 at 22:16 +0400, Alexander Shiyan wrote:
Description?
> Signed-off-by: Alexander Shiyan <shc_work@xxxxxxx>
> ---
> drivers/dma/imx-dma.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/dma/imx-dma.c b/drivers/dma/imx-dma.c
> index 6f9ac20..7ef16e8 100644
> --- a/drivers/dma/imx-dma.c
> +++ b/drivers/dma/imx-dma.c
> @@ -167,6 +167,7 @@ struct imxdma_channel {
> u32 ccr_to_device;
> bool enabled_2d;
> int slot_2d;
> + char name[6];
Will you go to use this further?
At least I didn't see in this patch series.
If yes, than attach corresponding patch to the series or explain this in
the commit message.
Otherwise, please, use local variables.
> };
>
> enum imx_dma_type {
> @@ -1111,7 +1112,7 @@ static int __init imxdma_probe(struct platform_device *pdev)
> }
>
> ret = devm_request_irq(&pdev->dev, irq_err,
> - imxdma_err_handler, 0, "DMA", imxdma);
> + imxdma_err_handler, 0, "DMAERR", imxdma);
> if (ret) {
> dev_warn(imxdma->dev, "Can't register ERRIRQ for DMA\n");
> goto err;
> @@ -1145,8 +1146,10 @@ static int __init imxdma_probe(struct platform_device *pdev)
> struct imxdma_channel *imxdmac = &imxdma->channel[i];
>
> if (!is_imx1_dma(imxdma)) {
> + sprintf(imxdmac->name, "DMA%i", i);
> ret = devm_request_irq(&pdev->dev, irq + i,
> - dma_irq_handler, 0, "DMA", imxdma);
> + dma_irq_handler, 0,
> + imxdmac->name, imxdma);
Is it necessary at all? As I can see the interrupts go in sequence. What
kind of help of those number attached? Describe in the commit message.
> if (ret) {
> dev_warn(imxdma->dev, "Can't register IRQ %d "
> "for DMA channel %d\n",
--
Andy Shevchenko <andriy.shevchenko@xxxxxxxxx>
Intel Finland Oy
---------------------------------------------------------------------
Intel Finland Oy
Registered Address: PL 281, 00181 Helsinki
Business Identity Code: 0357606 - 4
Domiciled in Helsinki
This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.
��.n��������+%������w��{.n��������)�)�� jg��� �����ݢj����G���� ���j:+v���w�m������w�������h�����٥
