Re: [PATCH 2/4] dma: imx-dma: Use dev_err() for reporting errors

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, 2014-02-22 at 22:16 +0400, Alexander Shiyan wrote:

Detailed description?

> Signed-off-by: Alexander Shiyan <shc_work@xxxxxxx>
> ---
>  drivers/dma/imx-dma.c | 9 ++++-----
>  1 file changed, 4 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/dma/imx-dma.c b/drivers/dma/imx-dma.c
> index 7ef16e8..bc78142 100644
> --- a/drivers/dma/imx-dma.c
> +++ b/drivers/dma/imx-dma.c
> @@ -1101,7 +1101,7 @@ static int __init imxdma_probe(struct platform_device *pdev)
>  		ret = devm_request_irq(&pdev->dev, irq,
>  				       dma_irq_handler, 0, "DMA", imxdma);
>  		if (ret) {
> -			dev_warn(imxdma->dev, "Can't register IRQ for DMA\n");
> +			dev_err(imxdma->dev, "Can't register IRQ for DMA\n");
>  			goto err;
>  		}
>  
> @@ -1114,7 +1114,7 @@ static int __init imxdma_probe(struct platform_device *pdev)
>  		ret = devm_request_irq(&pdev->dev, irq_err,
>  				       imxdma_err_handler, 0, "DMAERR", imxdma);
>  		if (ret) {
> -			dev_warn(imxdma->dev, "Can't register ERRIRQ for DMA\n");
> +			dev_err(imxdma->dev, "Can't register ERRIRQ for DMA\n");
>  			goto err;
>  		}
>  	}
> @@ -1151,9 +1151,8 @@ static int __init imxdma_probe(struct platform_device *pdev)
>  					       dma_irq_handler, 0,
>  					       imxdmac->name, imxdma);
>  			if (ret) {
> -				dev_warn(imxdma->dev, "Can't register IRQ %d "
> -					 "for DMA channel %d\n",
> -					 irq + i, i);
> +				dev_err(imxdma->dev, "Can't register IRQ %d "
> +					"for DMA channel %d\n", irq + i, i);

You may live string concatenated, since it's better to grep, like

				dev_warn(imxdma->dev,
					 "Can't register IRQ %d for DMA channel %d\n",
					 irq + i, i);

>  				goto err;
>  			}
>  			init_timer(&imxdmac->watchdog);


-- 
Andy Shevchenko <andriy.shevchenko@xxxxxxxxx>
Intel Finland Oy
---------------------------------------------------------------------
Intel Finland Oy
Registered Address: PL 281, 00181 Helsinki 
Business Identity Code: 0357606 - 4 
Domiciled in Helsinki 

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.
��.n��������+%������w��{.n��������)�)��jg��������ݢj����G�������j:+v���w�m������w�������h�����٥





[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux PCI]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux