On 10/1/24 11:11 AM, Mikulas Patocka wrote:
...
If I add that 'reboot-on-eio' flag, should it also restart the kernel with
kernel_restart("dm-verity device corrupted")? Or, should it use a
different string?
If we are already here revisiting it, maybe think if there are more errors that
should be catch (anything from crypto API?).
The name then should be different (no hardcoded "eio").
Also, isn't better to use just one flag and create something like
restart_on_corruption_and_error
panic_on_corruption_and_error
(that includes on_corruption AND additional error).
This will save us some flag combination checking in userspace :-)
(As I think restart on error without restart on corruption makes no sense.)
Milan
