The driver complains during self-testing, however, those errors seem to
be thrown during aes testing not sha256 testing:
# dmesg | grep -iE 'crypt|alg:'
[ 0.316442] alg: extra crypto tests enabled. This is intended for
developer use only.
[ 1.055440] mxs-dcp 2280000.crypto: Invalid block size!
[ 1.060927] mxs-dcp 2280000.crypto: Invalid block size!
[ 1.164247] mxs-dcp 2280000.crypto: Invalid block size!
[ 1.169591] mxs-dcp 2280000.crypto: Invalid block size!
[ 1.204738] mxs-dcp 2280000.crypto: Invalid block size!
[ 1.210093] mxs-dcp 2280000.crypto: Invalid block size!
[ 1.371876] mxs-dcp 2280000.crypto: Invalid block size!
[ 1.377280] mxs-dcp 2280000.crypto: Invalid block size!
[ 1.394093] mxs-dcp 2280000.crypto: Invalid block size!
[ 1.399432] mxs-dcp 2280000.crypto: Invalid block size!
[ 1.431509] mxs-dcp 2280000.crypto: Invalid block size!
[ 1.436904] mxs-dcp 2280000.crypto: Invalid block size!
The sha256-dcp self-test is reported as "passed".
I have tried to reproduce the issue by forcing many concurrent sha256
operations from userspace using AF_ALG but I haven't been able to see
any issues. Of course, this goes through the userspace crypto API, so it
might not be the same as the kernel using it directly.
Any tips on how to narrow in on this issue are appreciated :)
Best regards,
Sven
On 6/7/24 7:22 AM, Eric Biggers wrote:
On Thu, Jun 06, 2024 at 03:12:26PM +0200, Sven wrote:
Do you happen to have some more infos on the self-tests you mentioned? Can
you point me at documentation, I coulnd't really find much useful stuff.
Thanks
On 5/28/24 9:42 PM, Eric Biggers wrote:
Does this driver pass all the crypto self-tests?
The crypto self-tests can be enabled by unsetting
CONFIG_CRYPTO_MANAGER_DISABLE_TESTS, and preferably setting
CONFIG_CRYPTO_MANAGER_EXTRA_TESTS in order to enable the full set of tests.
They might catch something, though they don't test parallel usage of drivers
which is where it sounds like the issue here might be here.
In any case the bug here is likely to be in the mxs-dcp driver, especially
considering that drivers tend to be much lower quality than the software crypto
(some driver developers apparently don't even bother to run the tests).
- Eric
