Re: don't use ->bd_inode to access the block device size

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: don't use ->bd_inode to access the block device size
From: Wol <antlists@xxxxxxxxxxxxxxx>
Date: Thu, 14 Oct 2021 16:35:49 +0100
Cc: "linux-raid@xxxxxxxxxxxxxxx" <linux-raid@xxxxxxxxxxxxxxx>, "jfs-discussion@xxxxxxxxxxxxxxxxxxxxx" <jfs-discussion@xxxxxxxxxxxxxxxxxxxxx>, "linux-nilfs@xxxxxxxxxxxxxxx" <linux-nilfs@xxxxxxxxxxxxxxx>, "linux-scsi@xxxxxxxxxxxxxxx" <linux-scsi@xxxxxxxxxxxxxxx>, "linux-ntfs-dev@xxxxxxxxxxxxxxxxxxxxx" <linux-ntfs-dev@xxxxxxxxxxxxxxxxxxxxx>, "ntfs3@xxxxxxxxxxxxxxx" <ntfs3@xxxxxxxxxxxxxxx>, "linux-bcache@xxxxxxxxxxxxxxx" <linux-bcache@xxxxxxxxxxxxxxx>, "linux-nvme@xxxxxxxxxxxxxxxxxxx" <linux-nvme@xxxxxxxxxxxxxxxxxxx>, "reiserfs-devel@xxxxxxxxxxxxxxx" <reiserfs-devel@xxxxxxxxxxxxxxx>, "linux-block@xxxxxxxxxxxxxxx" <linux-block@xxxxxxxxxxxxxxx>, "dm-devel@xxxxxxxxxx" <dm-devel@xxxxxxxxxx>, "target-devel@xxxxxxxxxxxxxxx" <target-devel@xxxxxxxxxxxxxxx>, "linux-mtd@xxxxxxxxxxxxxxxxxxx" <linux-mtd@xxxxxxxxxxxxxxxxxxx>, "linux-fsdevel@xxxxxxxxxxxxxxx" <linux-fsdevel@xxxxxxxxxxxxxxx>, "linux-ext4@xxxxxxxxxxxxxxx" <linux-ext4@xxxxxxxxxxxxxxx>, "linux-nfs@xxxxxxxxxxxxxxx" <linux-nfs@xxxxxxxxxxxxxxx>, "linux-btrfs@xxxxxxxxxxxxxxx" <linux-btrfs@xxxxxxxxxxxxxxx>, "drbd-dev@xxxxxxxxxxxxxxxx" <drbd-dev@xxxxxxxxxxxxxxxx>
In-reply-to: <202110140813.44C95229@keescook>
References: <20211013051042.1065752-1-hch@lst.de> <20211014062844.GA25448@lst.de> <3AB8052D-DD45-478B-85F2-BFBEC1C7E9DF@tuxera.com> <a5eb3c18-deb2-6539-cc24-57e6d5d3500c@oracle.com> <202110140813.44C95229@keescook>
User-agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0

On 14/10/2021 16:14, Kees Cook wrote:

I don't really mind bdev_size since it's analogous to i_size, but
bdev_nr_bytes seems good to me.

I much prefer bdev_nr_bytes(), as "size" has no units.


Does it mean size IN bytes, or size OF A byte? :-)

Cheers,
Wol

--
dm-devel mailing list
dm-devel@xxxxxxxxxx
https://listman.redhat.com/mailman/listinfo/dm-devel

References:
- don't use ->bd_inode to access the block device size
  - From: Christoph Hellwig
- Re: don't use ->bd_inode to access the block device size
  - From: Christoph Hellwig
- Re: don't use ->bd_inode to access the block device size
  - From: Anton Altaparmakov
- Re: don't use ->bd_inode to access the block device size
  - From: Dave Kleikamp
- Re: don't use ->bd_inode to access the block device size
  - From: Kees Cook

Prev by Date: Re: don't use ->bd_inode to access the block device size
Next by Date: Re: don't use ->bd_inode to access the block device size
Previous by thread: Re: don't use ->bd_inode to access the block device size
Next by thread: simplify I/O size calculation helpers v2
Index(es):
- Date
- Thread

[Index of Archives] [DM Crypt] [Fedora Desktop] [ATA RAID] [Fedora Marketing] [Fedora Packaging] [Fedora SELinux] [Yosemite Discussion] [KDE Users] [Fedora Docs]