Re: [PATCH 09/11] block: remove unsed param in blk_fill_rwbs()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH 09/11] block: remove unsed param in blk_fill_rwbs()
From: Chaitanya Kulkarni <Chaitanya.Kulkarni@xxxxxxx>
Date: Wed, 1 Jul 2020 04:38:31 +0000
Accept-language: en-US
Cc: "axboe@xxxxxxxxx" <axboe@xxxxxxxxx>, "paolo.valente@xxxxxxxxxx" <paolo.valente@xxxxxxxxxx>, "sagi@xxxxxxxxxxx" <sagi@xxxxxxxxxxx>, "snitzer@xxxxxxxxxx" <snitzer@xxxxxxxxxx>, "fangguoju@xxxxxxxxx" <fangguoju@xxxxxxxxx>, "rdunlap@xxxxxxxxxxxxx" <rdunlap@xxxxxxxxxxxxx>, "rostedt@xxxxxxxxxxx" <rostedt@xxxxxxxxxxx>, "ming.lei@xxxxxxxxxx" <ming.lei@xxxxxxxxxx>, "linux-block@xxxxxxxxxxxxxxx" <linux-block@xxxxxxxxxxxxxxx>, "dm-devel@xxxxxxxxxx" <dm-devel@xxxxxxxxxx>, "mingo@xxxxxxxxxx" <mingo@xxxxxxxxxx>, "colyli@xxxxxxx" <colyli@xxxxxxx>, "jack@xxxxxxxx" <jack@xxxxxxxx>, "agk@xxxxxxxxxx" <agk@xxxxxxxxxx>, "bvanassche@xxxxxxx" <bvanassche@xxxxxxx>
Ironport-sdr: F8/BEa7lOjs5Hk/g/KKN+hai27PSzZdYe8ZPy05g/b8ZebWDKrh1L14hzveAwsK+iif4gmP1es NngwuhoAw6dys2J6UeGzWYCwgjA5XVxbgLmIIPxE5bw3OvbCxzwjk0ZjSd5n4IxGPn/kUxNtl2 kL11PgEqgrx10kua4KFSIxF/KgzStKI6NEa4n5zuE/4hqlqAO8Kb51yRLNfIFlWQ8/p84uAmtV NYz8lMoCPvm/crM/Tr0JrDu/QnrMsO6FCIG7ryyArpEoU2tBkja981Am/Q+MHNcjZwdhoPQ3JU NXU=
References: <20200629234314.10509-1-chaitanya.kulkarni@wdc.com> <20200629234314.10509-10-chaitanya.kulkarni@wdc.com> <20200630051247.GF27033@lst.de>
Wdcipoutbound: EOP-TRUE

On 6/29/20 10:12 PM, Christoph Hellwig wrote:
>> +extern void blk_fill_rwbs(char *rwbs, unsigned int op);
> You might want to drop the extern while you're at it.
> 

Good point.



--
dm-devel mailing list
dm-devel@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/dm-devel

References:
- [PATCH 00/10] block: blktrace framework cleanup
  - From: Chaitanya Kulkarni
- [PATCH 09/11] block: remove unsed param in blk_fill_rwbs()
  - From: Chaitanya Kulkarni
- Re: [PATCH 09/11] block: remove unsed param in blk_fill_rwbs()
  - From: Christoph Hellwig

Prev by Date: Re: [PATCH 07/11] block: get rid of blk_trace_request_get_cgid()
Next by Date: Re: [PATCH 10/11] block: use block_bio class for getrq and sleeprq
Previous by thread: Re: [PATCH 09/11] block: remove unsed param in blk_fill_rwbs()
Next by thread: [PATCH 04/11] block: use block_bio event class for bio_bounce
Index(es):
- Date
- Thread

[Index of Archives] [DM Crypt] [Fedora Desktop] [ATA RAID] [Fedora Marketing] [Fedora Packaging] [Fedora SELinux] [Yosemite Discussion] [KDE Users] [Fedora Docs]