On Wed, 2018-08-01 at 15:57 -0500, Benjamin Marzinski wrote: +AD4- I realize that this locking was added to make an analyzer happy, +AD4- presumably because sometimes ct-+AD4-devt was being accessed while ct-+AD4-devt +AD4- was held, and sometimes not. The tur checker locking will be cleaned +AD4- up in a later patch to deal with this. Are you perhaps referring to commit 873be9fef222 (+ACI-libmultipath/checkers/tur: Serialize tur+AF8-checker+AF8-context.devt accesses+ACI-)? Your assumption about how DRD works is wrong. DRD doesn't care about which mutex or other synchronization primitives are used to serialize accesses to data that is shared between threads. All it cares about is that concurrent accesses to shared data are serialized. I'm afraid that your patch reintroduces the race conditions that were fixed by commit 873be9fef222. Have you considered to fix this without removing the locking? Bart.
-- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel
