On Sat, Aug 04 2018 at 1:04pm -0400, Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote: > On Sat, Aug 4, 2018 at 3:03 AM WGH <wgh@xxxxxxxxx> wrote: > > > > > > > The patch works for me. > > > > However, there's no text messsage in the kernel log, just a traceback. I > > think that's because WARN_ONCE is supposed to take condition as a first > > argument. > > Duh. > > It needs to be WARN_ONCE(1, ...); > > I obviously didn't test that patch, but I _did_ compile it. I wonder > why I didn't get a compiler warning for it... > > [ Goes off and looks ] > > Oh, because the "bio_devname(bio, b)" argument ended up being > interpreted as the format string, and since it was a dynamic string > the compiler felt it was all fine. Just bad luck. > > Anyway, just out of curiosity, what was the traceback? > > I'm not entirely happy with that patch either (even after the obvious > fix to add the "1" argument), but it does seem like the minimal > temporary workaround for now. I agree. Please feel free to add my: Acked-by: Mike Snitzer <snitzer@xxxxxxxxxx> -- dm-devel mailing list dm-devel@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/dm-devel
