On Mon, Jun 4, 2018 at 2:13 PM Mike Snitzer <snitzer@xxxxxxxxxx> wrote:
>
> (Mikulas would like to still use swait for the dm-writecache's endio
> thread, since endio_thread_wait only has a single waiter.
If you already know it has a single waiter, please don't use a queue at all.
Just have the "struct task_struct *" in the waiter field, and use
"wake_up_process()". Use NULL for "no process".
That's *much* simpler than swait(), and is a well-accepted traditional
wake interface. It's also really really obvious.
The "there is only a single waiter" is *NOT* an excuse for using
swait. Quite the reverse. Using swait is stupid, slow, and complex.
And it generates code that is harder to understand.
And yes, the fact that KVM also made that completely idiotic choice in
their apic code is not an excuse either. I have no idea why they did
it either. It's stupid. In the kvm case, I think what happened was
that they had a historical wait-queue model, and they just didn't
realize that they al;ways had just one waiter, so then they converted
a waitqueue to a swait queue.
But if you already know there is only ever one waiter, please don't do
that. Just avoid queues entirely.
Linus
--
dm-devel mailing list
dm-devel@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/dm-devel
